yahoo-eng-team team mailing list archive

[OpenStack Infra <1596829@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/347155
Committed: https://git.openstack.org/cgit/openstack/python-neutronclient/commit/?id=ec20f7f85c3a8ecd788536401eeeb0fef4ef18c2
Submitter: Jenkins
Branch:    master

commit ec20f7f85c3a8ecd788536401eeeb0fef4ef18c2
Author: Takashi NATSUME <natsume.takashi@xxxxxxxxxxxxx>
Date:   Tue Jul 26 15:48:11 2016 +0900

    Fix string interpolation at logging call
    
    Skip creating the formatted log message
    if the message is not going to be emitted
    because of the log level.
    
    Change-Id: I19d985addb2bdc1b5e17ecd5ac90223e5347d7b2
    Closes-Bug: #1596829


** Changed in: python-neutronclient
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1596829

Title:
  String interpolation should be delayed at logging calls

Status in Ceilometer:
  New
Status in Glance:
  In Progress
Status in glance_store:
  New
Status in heat:
  New
Status in Ironic:
  Fix Released
Status in OpenStack Identity (keystone):
  New
Status in networking-vsphere:
  Fix Released
Status in neutron:
  Fix Released
Status in OpenStack Compute (nova):
  In Progress
Status in os-brick:
  Fix Released
Status in python-cinderclient:
  Fix Released
Status in python-glanceclient:
  In Progress
Status in python-neutronclient:
  Fix Released
Status in OpenStack Object Storage (swift):
  New
Status in taskflow:
  New

Bug description:
  String interpolation should be delayed to be handled by the logging
  code, rather than being done at the point of the logging call.

  Wrong: LOG.debug('Example: %s' % 'bad')
  Right: LOG.debug('Example: %s', 'good')

  See the following guideline.

  * http://docs.openstack.org/developer/oslo.i18n/guidelines.html
  #adding-variables-to-log-messages

  The rule for it should be added to hacking checks.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ceilometer/+bug/1596829/+subscriptions