yahoo-eng-team team mailing list archive

[OpenStack Infra <1597000@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/326641
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=617042b9cb516ba8c6b502990018adea8e3dd2eb
Submitter: Jenkins
Branch:    master

commit 617042b9cb516ba8c6b502990018adea8e3dd2eb
Author: Timur Sufiev <tsufiev@xxxxxxxxxxxx>
Date:   Tue Jun 7 19:42:37 2016 +0300

    Allow wiring of <hz-dynamic-table> into <transfer-table>
    
    The framework change consists of 2 parts:
    
    * Provide filterAvailable filter to be used inside 'items' value of
      <hz-dynamic-table> instead of 'ng-if' directve which was used before
      in manually written table layout (no longer possible with dynamic
      tables). This filter solves the task of hiding the available values
      once they become allocated.
    * Provide 'allocateItemAction' and 'deallocateItemAction' actions on
      transfer-table controller which are compatible with 'itemActions'
      attribute of <hz-dynamic-table>.
    
    Keypairs tab in Angular Launch Instance wizard is rewritten to use the
    new approach.
    
    Also a nasty bug within <hz-dynamic-table> was fixed: `scope.items`
    value was set in hz-dynamic-table's post-linking function before,
    which lead to `undefined` value arriving into st-table directive,
    because st-table was linked before hz-dynamic-table as its child
    (that's how postLink function works). Directive st-table under some
    circustances was wrapping `undefined` into `[]`, causing various
    issues with table row equal to `undefined`. The solution to that
    problem was to extract setting `scope.items = []` to a pre-linking
    function, so by the time st-table is linked, there is already an empty
    array under scope's 'items' property.
    
    Closes-Bug: #1597000
    Change-Id: Ia6d707d793cefd75d869b061a313390110f620cf


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1597000

Title:
  Directives <transfer-table> and <hz-dynamic-table> don't work nicely
  together

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  New directive <hz-dynamic-table> provides an elegant way to reduce the
  amount of boilerplate html templates one had to provide recently to
  render tables. Unfortunately, <transfer-table> doesn't work with it
  because of its internal structure and it's necessary to use the old
  verbose markup inside its <available> and <allocated> sibling tags.
  This has to be fixed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1597000/+subscriptions