← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1606269] Re: Incorrect flavor in request_spec on resize

 

Reviewed:  https://review.openstack.org/347387
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=74ab427d4796d8a386f84a15cc49188c2a60f8f1
Submitter: Jenkins
Branch:    master

commit 74ab427d4796d8a386f84a15cc49188c2a60f8f1
Author: Sylvain Bauza <sbauza@xxxxxxxxxx>
Date:   Tue Jul 26 15:29:37 2016 +0200

    Update RequestSpec nested flavor when a resize comes in
    
    There was a regression (because of a PEBKAC) when we implemented calling the
    original RequestSpec because we weren't updating the flavor so the scheduler
    was verifying the original flavor instead of the new one.
    
    Change-Id: I8abdf58a6537dd5e15a012ea37a7b48abd726579
    Closes-Bug: #1606269


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1606269

Title:
  Incorrect flavor in request_spec on resize

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  On resizes, the RequestSpec object sent to the scheduler contains the
  instance's original flavor.  This is causing an issue in our scheduler
  because it is not seeing a new flavor for the resize tasking.

  The issue appears to be that at
  https://github.com/openstack/nova/blob/76dfb4ba9fa0fed1350021591956c4e8143b1ce9/nova/conductor/tasks/migrate.py#L52
  the RequestSpec is hydrated with self.instance.flavor than the new
  flavor which is  self.flavor.

  Issue discovered in newtwon nova and appeared after
  https://github.com/openstack/nova/commit/76dfb4ba9fa0fed1350021591956c4e8143b1ce9?diff=split
  #diff-b839034e35c154b8c3a1c65bf7791eefL42

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1606269/+subscriptions


References