← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1606988] Re: saving metadata of array type error

 

Reviewed:  https://review.openstack.org/348119
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=12f9ef8d54fdd4eaf73a2f521632964bf5a84571
Submitter: Jenkins
Branch:    master

commit 12f9ef8d54fdd4eaf73a2f521632964bf5a84571
Author: Travis Tripp <travis.tripp@xxxxxxx>
Date:   Wed Jul 27 22:42:36 2016 -0600

    Remove array metadata when no items + fix case
    
    Array metadata appends an operator automatically, which
    means the value will still contain something and it
    doesn't get detected for removal.
    
    In addition, bad APIs like glance v1 will store a property
    with mixed case, but then return only lower case when
    listing them. However, it will not remove the property
    when you request to remove it unless it matches the original
    case (sad panda).  So, this patch will reset the proper
    casing for properties defined as metadata definitions before
    making the request to save the metadata.
    
    Change-Id: I1e5a6fde35b7be6118f21ac46ad0aea088280215
    Closes-Bug: 1606988


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1606988

Title:
  saving metadata of array type error

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  After saving metadata of type array on an image, when you go to edit
  and remove that metadata and re-save. Metadata is not removed and
  remains on the image.

  To reproduce:
  If you don't have metadata with an array type, add the json in the file attached at:
   - /admin/metadata_defs > Import Namespace

  Then go to:
   - /admin/images and Update Metadata on one of the images.

  Add one of the Storage Types (eg. SAN_storage) and click Save. Notice
  metadata saved to image on image detail page.

  After it saves, click Update Metadata for the same image. Remove the
  metadata you just added in the previous step and click Save. After
  saving notice that metadata is still on the image and was not deleted.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1606988/+subscriptions


References