yahoo-eng-team team mailing list archive
-
yahoo-eng-team team
-
Mailing list archive
-
Message #54544
[Bug 1608623] Re: Policy service caching does not work within hz-dynamic-table
Reviewed: https://review.openstack.org/349594
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=deda07c4c35c1bc5a80a76c0e8041a8a4bd57874
Submitter: Jenkins
Branch: master
commit deda07c4c35c1bc5a80a76c0e8041a8a4bd57874
Author: Travis Tripp <travis.tripp@xxxxxxx>
Date: Fri Jul 8 17:04:31 2016 -0600
Memoize policy service
There is a hole in the policy service caching layer
that has something to do with ng-repeat. The angular
http cache service doesn't seem to work within a single
digest cycle or something... so I simplfied and
improved performance by using memoize to
prevent redundant checks which were happening in
hz-dynamic-table.
See bug for details on verifying this manually.
Change-Id: Ib0b3a806d1c6b065e20cb22b8255048bd836dd1b
Closes-Bug: 1608623
** Changed in: horizon
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1608623
Title:
Policy service caching does not work within hz-dynamic-table
Status in OpenStack Dashboard (Horizon):
Fix Released
Bug description:
The policy service caching (where it ensures that if you look up the
same policy more than once) does not seem to work under hz-dynamic-
table.
Turn on ng-images which recently migrated to hz-dynamic-table and
watch the network calls. You'll note a bunch of policy calls and if
you look at the request body, you'll see the same rules going in
multiple times.
http://imgur.com/a/Sh4fj
To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1608623/+subscriptions
References