yahoo-eng-team team mailing list archive
-
yahoo-eng-team team
-
Mailing list archive
-
Message #54565
[Bug 1561558] Re: Untranslated help text found in Launch Instance window
Reviewed: https://review.openstack.org/349442
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=e3ef7ae51caa91dc7365e6ded634387f59141c43
Submitter: Jenkins
Branch: master
commit e3ef7ae51caa91dc7365e6ded634387f59141c43
Author: Kenji Ishii <ken-ishii@xxxxxxxxxxxxx>
Date: Mon Aug 1 19:04:08 2016 +0900
Fix untranslated help text in Launch Instance window
- Source tab
Flow context is not allowed to write to inner phrasing content,
At the moment untranslation is occurred by a incorrect value of .html().
<p translate><li>yyy</li></p> -> elem.html() // value is ''
<p translate>xxx<li>yyy</li></p> -> elem.html() // value is 'xxx'
This phenomenon is caused by below.
html in html file
<p translate><li>yyy</li>xxx</p>
html rendered in browser
<p tramslate></p><li>yyy</li><p></p>
- Security Groups tab
'&' needs html escape
Change-Id: Ic414d232063cc12333ac2d70fd8f351a35a00b6d
Closes-Bug: #1561558
** Changed in: horizon
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1561558
Title:
Untranslated help text found in Launch Instance window
Status in OpenStack Dashboard (Horizon):
Fix Released
Bug description:
Project > Instances > Launch Instance > Source
Project > Instances > Launch Instance > Security Groups
Found the following untranslated help text in Launch Instance window.
[Source tab]
Image: This option uses an image to boot the instance.
Instance Snapshot: This option uses an instance snapshot to boot the instance.
Image (with Create New Volume checked): This options uses an image to
boot the instance, and creates a new volume to persist instance data.
You can specify volume size and whether to delete the volume on
deletion of the instance.
Volume: This option uses a volume that already exists. It does not
create a new volume. You can choose to delete the volume on deletion
of the instance. Note: when selecting Volume, you can only launch one
instance.
Volume Snapshot: This option uses a volume snapshot to boot the
instance, and creates a new volume to persist instance data. You can
choose to delete the volume on deletion of the instance.
[Security Groups tab]
Security groups define a set of IP filter rules that determine how
network traffic flows to and from an instance. Users can add
additional rules to an existing security group to further define the
access options for an instance. To create additional rules, go to the
Compute | Access & Security view, then find the security group and
click Manage Rules.
Translations are already completed in Zanata and other latest
translations have been imported to the test envrionment.
To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1561558/+subscriptions
References