yahoo-eng-team team mailing list archive

[OpenStack Infra <1596829@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/349768
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=0fe151d07f1f77bec1e8b7827823bf7197b52408
Submitter: Jenkins
Branch:    master

commit 0fe151d07f1f77bec1e8b7827823bf7197b52408
Author: LiuNanke <nanke.liu@xxxxxxxxxxxx>
Date:   Tue Aug 2 11:20:41 2016 +0800

    Fix string interpolation to delayed by logging
    
    String interpolation should be delayed to be handled by the logging
    code, rather than being done at the point of the logging call.
    
    See the oslo i18n guideline.
    * http://docs.openstack.org/developer/oslo.i18n/guidelines.html
    
    References: https://review.openstack.org/#/c/339268
    
    Change-Id: Ie4ea466f951db796fd85277c52be40018dfb01ac
    Closes-Bug:#1596829


** Changed in: murano
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1596829

Title:
  String interpolation should be delayed at logging calls

Status in Ceilometer:
  New
Status in Glance:
  In Progress
Status in glance_store:
  New
Status in heat:
  New
Status in Ironic:
  Fix Released
Status in masakari:
  In Progress
Status in Murano:
  Fix Released
Status in networking-vsphere:
  Fix Released
Status in neutron:
  Fix Released
Status in OpenStack Compute (nova):
  In Progress
Status in os-brick:
  Fix Released
Status in os-vif:
  In Progress
Status in python-cinderclient:
  Fix Released
Status in python-glanceclient:
  Fix Released
Status in python-neutronclient:
  Fix Released
Status in OpenStack Object Storage (swift):
  New
Status in taskflow:
  New

Bug description:
  String interpolation should be delayed to be handled by the logging
  code, rather than being done at the point of the logging call.

  Wrong: LOG.debug('Example: %s' % 'bad')
  Right: LOG.debug('Example: %s', 'good')

  See the following guideline.

  * http://docs.openstack.org/developer/oslo.i18n/guidelines.html
  #adding-variables-to-log-messages

  The rule for it should be added to hacking checks.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ceilometer/+bug/1596829/+subscriptions