yahoo-eng-team team mailing list archive

[OpenStack Infra <1596829@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/349807
Committed: https://git.openstack.org/cgit/openstack/masakari/commit/?id=cd3be63409146c960949708b952282b879a70e56
Submitter: Jenkins
Branch:    master

commit cd3be63409146c960949708b952282b879a70e56
Author: Takashi NATSUME <natsume.takashi@xxxxxxxxxxxxx>
Date:   Tue Aug 2 14:39:30 2016 +0900

    Add a hacking rule for string interpolation at logging
    
    String interpolation should be delayed to be handled
    by the logging code, rather than being done
    at the point of the logging call.
    So add a hacking rule for it.
    
    See the oslo i18n guideline.
    
    * http://docs.openstack.org/developer/oslo.i18n/guidelines.html
    
    Change-Id: Ib7d97e6edbb8069c12b22505c0d6653b4a17ec78
    Closes-Bug: #1596829


** Changed in: masakari
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1596829

Title:
  String interpolation should be delayed at logging calls

Status in Ceilometer:
  New
Status in congress:
  In Progress
Status in Glance:
  In Progress
Status in glance_store:
  New
Status in heat:
  New
Status in Ironic:
  Fix Released
Status in masakari:
  Fix Released
Status in networking-vsphere:
  Fix Released
Status in neutron:
  Fix Released
Status in OpenStack Compute (nova):
  In Progress
Status in os-brick:
  Fix Released
Status in os-vif:
  Fix Released
Status in python-cinderclient:
  Fix Released
Status in python-glanceclient:
  Fix Released
Status in python-neutronclient:
  Fix Released
Status in OpenStack Object Storage (swift):
  New
Status in taskflow:
  New

Bug description:
  String interpolation should be delayed to be handled by the logging
  code, rather than being done at the point of the logging call.

  Wrong: LOG.debug('Example: %s' % 'bad')
  Right: LOG.debug('Example: %s', 'good')

  See the following guideline.

  * http://docs.openstack.org/developer/oslo.i18n/guidelines.html
  #adding-variables-to-log-messages

  The rule for it should be added to hacking checks.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ceilometer/+bug/1596829/+subscriptions