yahoo-eng-team team mailing list archive

[OpenStack Infra <1608406@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/349401
Committed: https://git.openstack.org/cgit/openstack/neutron-dynamic-routing/commit/?id=11965147fea9a52156ac2be265a5662973a4e5ad
Submitter: Jenkins
Branch:    master

commit 11965147fea9a52156ac2be265a5662973a4e5ad
Author: LIU Yulong <liuyulong@xxxxxx>
Date:   Mon Aug 1 16:10:28 2016 +0800

    BGP: exclude legacy fip in DVR fip host routes query
    
    When query a bgpspeaker's routes, the DVR fip host routes query
    will get the routes including the central fip routes. This will
    let the central fip has more than one next_hop routes.
    
    This patch adds a RouterExtraAttributes check for the distributed
    routers during the DVR fip host routes query.
    
    Change-Id: Idb237d4563236c24c19abd8234cfdec4f2373eee
    Closes-Bug: #1608406


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1608406

Title:
  BGP: DVR fip host routes query including legacy/HA fip routes

Status in neutron:
  Fix Released

Bug description:
  ENV:
  neutron-8.1.2-1 (stable/mitaka)

  When query a bgpspeaker's routes, the DVR fip host routes query will get the routes including the central fip routes.
  This will let the central fip has more than one next_hop routes.

  For instance:
  +-----------------+--------------+
  | destination     | next_hop     |
  +-----------------+--------------+
  | 172.16.10.69/32 | 172.16.10.57 | (ha)
  | 172.16.10.69/32 | 172.16.10.65 | (ha)
  | 172.16.10.70/32 | 172.16.10.58 | (legacy)
  | 172.16.10.70/32 | 172.16.10.66 | (legacy)
  | 172.16.10.68/32 | 172.16.10.66 | (dvr)
  | 172.16.10.67/32 | 172.16.10.65 | (ha-and-dvr)
  +-----------------+--------------+

  public (external) network ports:
  172.16.10.69 network:floatingip
  172.16.10.70 network:floatingip
  172.16.10.68 network:floatingip
  172.16.10.67 network:floatingip
  172.16.10.66 network:floatingip_agent_gateway
  172.16.10.65 network:floatingip_agent_gateway
  172.16.10.59 network:router_gateway
  172.16.10.57 network:router_gateway
  172.16.10.58 network:router_gateway
  172.16.10.60 network:router_gateway

  This issue was tested in stable/mitaka, bug the upstream may also have the same issue.
  Because this line did not filter the legacy/HA fips' routes:
  https://github.com/openstack/neutron-dynamic-routing/blob/master/neutron_dynamic_routing/db/bgp_db.py#L732

  bgp routes, Routers, floating IPs, ports, networks:
  http://paste.openstack.org/show/547689/

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1608406/+subscriptions