yahoo-eng-team team mailing list archive

[Erik Colnick <erik.colnick@xxxxxxx>]

Public bug reported:

As currently implemented, the _check_vlan_transparency method in the
MechanismManager class will fail if there is any mechanism driver in the
configured mechanism drivers list which does not implement the
check_vlan_transparency method.  This is because the check for support
of vlan transparency currently fails if the call on the mechanism driver
check_vlan_transparency returns either False (the mechanism driver
explicitly advertises that it does not support vlan transparent networks
by overriding the check_vlan_transparency method inherited from the base
class) or if it returns 'None' (which is the result of the mechanism
driver not overriding the base class check_vlan_transparency method).

The initial implementation of vlan-transparency support in the
MechanismManager class only raised an error in the event that a driver
explicitly returned 'False' from its check_vlan_transparency method
(https://review.openstack.org/#/c/158420/18/neutron/plugins/ml2/managers.py),
however this logic was changed when the support was moved from core to
extension (https://review.openstack.org/#/c/169569/).

** Affects: neutron
     Importance: Undecided
         Status: New


** Tags: mitaka-backport-potential

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1611843

Title:
  MechanismManager fails to create vlan-transparent network incorrectly
  with legacy plugins

Status in neutron:
  New

Bug description:
  As currently implemented, the _check_vlan_transparency method in the
  MechanismManager class will fail if there is any mechanism driver in
  the configured mechanism drivers list which does not implement the
  check_vlan_transparency method.  This is because the check for support
  of vlan transparency currently fails if the call on the mechanism
  driver check_vlan_transparency returns either False (the mechanism
  driver explicitly advertises that it does not support vlan transparent
  networks by overriding the check_vlan_transparency method inherited
  from the base class) or if it returns 'None' (which is the result of
  the mechanism driver not overriding the base class
  check_vlan_transparency method).

  The initial implementation of vlan-transparency support in the
  MechanismManager class only raised an error in the event that a driver
  explicitly returned 'False' from its check_vlan_transparency method
  (https://review.openstack.org/#/c/158420/18/neutron/plugins/ml2/managers.py),
  however this logic was changed when the support was moved from core to
  extension (https://review.openstack.org/#/c/169569/).

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1611843/+subscriptions