yahoo-eng-team team mailing list archive

[OpenStack Infra <1584237@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/350259
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=3c26a621f34e1ec3369f2a9d2ce6066c6343c2be
Submitter: Jenkins
Branch:    master

commit 3c26a621f34e1ec3369f2a9d2ce6066c6343c2be
Author: Boden R <bodenvmw@xxxxxxxxx>
Date:   Tue Aug 2 14:33:49 2016 -0600

    Use neutron-lib add_validator for registration
    
    As per [1], neutron-lib 0.3.0 provides a public add/get API for
    local validator registration/access. This API is preferred over
    directly accessing the validators dict module-level attribute
    that's done today when adding a new validator and in fact
    direct access to the validators dict is deprecated.
    
    This patch changes all neutron's usage of the validators dict
    to use the public API.
    
    Closes-Bug: #1584237
    
    [1] https://review.openstack.org/#/c/324090/
    
    Change-Id: I97680b0a8d88cb753199fce7949cfb24b506a0ff


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1584237

Title:
  Support local validators

Status in neutron:
  Fix Released

Bug description:
  neutron-lib contains a number of API validators. If a new feature
  needs a new validator, there are two options available today:

  a) contribute the validator to neutron-lib/api and pull it down: this makes sense only if the validator can be useful across a number of projects;
  b) contribute the validator locally to the project of interest and modify the module variable neutron_lib.api.validators.validators with the local validator reference. This is definitely hack-ish and should be frowned upon; neutron-lib has a setter [1], but we'd want to clean/document things up a bit.

  For this reason, it would be nice to have a registration mechanism for
  local validators;

  [1] https://github.com/openstack/neutron-
  lib/blob/master/neutron_lib/api/validators.py#L526

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1584237/+subscriptions