← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1603162] Re: Pluggable IPAM rollback fails with reference driver

 

Reviewed:  https://review.openstack.org/348956
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=67984850228f6f26a72504b9f464a5fbcaac59e6
Submitter: Jenkins
Branch:    master

commit 67984850228f6f26a72504b9f464a5fbcaac59e6
Author: Carl Baldwin <carl.baldwin@xxxxxxx>
Date:   Fri Jul 29 10:10:48 2016 -0600

    Avoid IPAM driver reusing a session that has been rolled back
    
    With the in-tree pluggable IPAM driver, IPAM rollback tries to use the
    DB session after it has been rolled back due to an exception. This
    driver doesn't need roll back, so fix this by adding a method to the
    driver signalling that rollback shouldn't be attempted.
    
    Change-Id: Ic254789e58a8a51cd1aa943cb71de12410f4c0a7
    Closes-Bug: #1603162
    Related-Bug: #1516156


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1603162

Title:
  Pluggable IPAM rollback fails with reference driver

Status in neutron:
  Fix Released

Bug description:
  This bug is visible when pluggable IPAM is active.  It can be seen
  with this patch [1].  It does not cause gate failures but it is still
  something that should be understood.  This logstash query [2] seems to
  find where they occur.  It is helpful to look at the DEBUG level
  logging around the time of the error.  For example see this paste [3].

  It seems that the session gets broken with an exception that causes a
  rollback.  Then, the IPAM rollback attempts to use the same session
  for rollback which fails.  Should the reference pluggable IPAM driver
  be using a different session?  Or, should it call rollback?

  [1] https://review.openstack.org/#/c/181023
  [2] http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22IP%20deallocation%20failed%20on%20external%20system%5C%22
  [3] http://paste.openstack.org/show/532891/

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1603162/+subscriptions


References