← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1601822] Re: remotefs.RsyncDriver() should use utils.safe_ip_format()

 

Reviewed:  https://review.openstack.org/340386
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=270be6906c13bc621a7ad507b8ae729a940609d2
Submitter: Jenkins
Branch:    master

commit 270be6906c13bc621a7ad507b8ae729a940609d2
Author: Alexey I. Froloff <raorn@xxxxxxxxxx>
Date:   Mon Jul 11 16:31:09 2016 +0300

    Properly quote IPv6 address in RsyncDriver
    
    When IPv6 address literal is used as host in rsync call, it should be
    enclosed in square brackets.  This is already done for copy_file method
    outside of driver in changeset Ia5f28673e79158d948980f2b3ce496c6a56882af
    
    Create helper function format_remote_path(host, path) and use where
    appropriate.
    
    Closes-Bug: 1601822
    Change-Id: Ifc386539f33684fb764f5f638a7ee0a10b1ef534


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1601822

Title:
  remotefs.RsyncDriver() should use utils.safe_ip_format()

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  IPv6 address literal should be wrapped in square brackets when calling
  rsync:

  Resize error: not able to execute ssh command: Unexpected error while running command.
  Command: rsync --archive --relative --no-implied-dirs /tmp/tmpo_wpSz/./var/lib/nova/instances/fd7c6610-cf13-42e0-826c-3b4eb2494465 fd4b:cafe:dead:beef::bad:f00d:/
  Exit code: 255
  Stdout: u''
  Stderr: u'ssh: Could not resolve hostname fd4b: Name or service not known\r\nrsync: connection unexpectedly closed (0 bytes received so far) [sender]\nrsync error: unexplained error (code 255) at io.c(226) [sender=3.1.0]\n'

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1601822/+subscriptions


References