← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1611302] Re: SR-IOV: deprecate supported_pci_vendor_devs

 

Reviewed:  https://review.openstack.org/352812
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=de31df4211ca2b05c331ad910578893fe92052f4
Submitter: Jenkins
Branch:    master

commit de31df4211ca2b05c331ad910578893fe92052f4
Author: Moshe Levi <moshele@xxxxxxxxxxxx>
Date:   Mon Aug 8 20:44:30 2016 +0300

    SR-IOV: deprecate supported_pci_vendor_devs
    
    Deprecate the supported_pci_vendor_devs option in order to reduce
    complexity for configuring SR-IOV. Currently, neutron validates the pci
    vendor and product id. However this check is already done by the
    nova-scheduler when it selects a suitable hypervisor. More precisely,
    the compute node validates this through the pci_passthrough_whitelist
    option in nova.conf. Therefore this check in neutron is redundant.
    
    This patch deprecates the supported_pci_vendor_devs in Newton release
    and updates the supported_pci_vendor_devs default to None.
    In case of None value the SR-IOV mechanism driver won't do
    any pci vendor validation. In case this option is set
    the SR-IOV mechanism driver will do the validaiton as it was
    before.
    
    DocImpact
    Closes-bug: #1611302
    
    Change-Id: Id5e2cef44da871965583abbae3e1140fd4f5786c


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1611302

Title:
  SR-IOV: deprecate supported_pci_vendor_devs

Status in neutron:
  Fix Released

Bug description:
  To reduce complexity in configuring SR-IOV I want to deprecate
  the supported_pci_vendor_devs option. This option is doing extra
  validation that pci vendor id and product id provided by
  nova in the neutron port binding profile is matching
  to the vendor id and product id  in supported_pci_vendor_devs.
  This is redundant, because nova-scheduler is the point to do
  validation and select a suitable hypervisor and  The compute node is
  already validating this through the pci_passthrough_whitelist
  option in nova.conf

  
  see http://lists.openstack.org/pipermail/openstack-dev/2016-August/101108.html

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1611302/+subscriptions


References