yahoo-eng-team team mailing list archive

[Manjeet Singh Bhatia <manjeet.s.bhatia@xxxxxxxxx>]

Public bug reported:

neutron api pass qos data to notification, 
which is qos_policy object

qos_policy like QosPolicy(description='',id=58c5f284-bc0d-420d-9aac-
69b3e7cc6e0c,name='testpolicy-0',rules=[QosRule(403c3298-d51a-
41d3-99f2-bd5cbc698448),QosRule(5c157ba8-0168-4ca9-abbf-
93a0e7483f48)],shared=False,tenant_id='1cbe81ac17ed4703988cd390d4f0dc39')

{'description': u'', 'rules': [{'max_kbps': 100, 'type':
'bandwidth_limit', 'id': '403c3298-d51a-41d3-99f2-bd5cbc698448',
'max_burst_kbps': 0, 'qos_policy_id': '58c5f284-bc0d-420d-9aac-
69b3e7cc6e0c'}, {'dscp_mark': 14, 'type': 'dscp_marking', 'id':
'5c157ba8-0168-4ca9-abbf-93a0e7483f48', 'qos_policy_id': '58c5f284-bc0d-
420d-9aac-69b3e7cc6e0c'}], 'tenant_id':
u'1cbe81ac17ed4703988cd390d4f0dc39', 'shared': False, 'id': '58c5f284
-bc0d-420d-9aac-69b3e7cc6e0c', 'name': u'testpolicy-0'}

Since we can attach only one rule of each type, this format is little confusing, 
having rules key in dict can be mistaken as supporting multiple rules by policy. 

so relevant format would be

{'description': '', 
 'bandwidth-limit-rule': {}
 'dscp-marking-rule': {}
 'policy-id' : ''
 'project-id': ''
}

and other minor thing, same qos-policy-id can be seen thrice in same
data, we have to specify policy while creating rule of any type, so it
would make sense to pass qos-policy-id just once.

** Affects: neutron
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1616253

Title:
  QoS api need to reformat  qos_policy_data

Status in neutron:
  New

Bug description:
  neutron api pass qos data to notification, 
  which is qos_policy object

  qos_policy like QosPolicy(description='',id=58c5f284-bc0d-420d-9aac-
  69b3e7cc6e0c,name='testpolicy-0',rules=[QosRule(403c3298-d51a-
  41d3-99f2-bd5cbc698448),QosRule(5c157ba8-0168-4ca9-abbf-
  93a0e7483f48)],shared=False,tenant_id='1cbe81ac17ed4703988cd390d4f0dc39')

  {'description': u'', 'rules': [{'max_kbps': 100, 'type':
  'bandwidth_limit', 'id': '403c3298-d51a-41d3-99f2-bd5cbc698448',
  'max_burst_kbps': 0, 'qos_policy_id': '58c5f284-bc0d-420d-9aac-
  69b3e7cc6e0c'}, {'dscp_mark': 14, 'type': 'dscp_marking', 'id':
  '5c157ba8-0168-4ca9-abbf-93a0e7483f48', 'qos_policy_id': '58c5f284
  -bc0d-420d-9aac-69b3e7cc6e0c'}], 'tenant_id':
  u'1cbe81ac17ed4703988cd390d4f0dc39', 'shared': False, 'id': '58c5f284
  -bc0d-420d-9aac-69b3e7cc6e0c', 'name': u'testpolicy-0'}

  Since we can attach only one rule of each type, this format is little confusing, 
  having rules key in dict can be mistaken as supporting multiple rules by policy. 

  so relevant format would be

  {'description': '', 
   'bandwidth-limit-rule': {}
   'dscp-marking-rule': {}
   'policy-id' : ''
   'project-id': ''
  }

  and other minor thing, same qos-policy-id can be seen thrice in same
  data, we have to specify policy while creating rule of any type, so it
  would make sense to pass qos-policy-id just once.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1616253/+subscriptions