yahoo-eng-team team mailing list archive
-
yahoo-eng-team team
-
Mailing list archive
-
Message #55493
[Bug 1613466] Re: Update credential to "ec2" type accepts a credential without the project set
Reviewed: https://review.openstack.org/357950
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=8144e28336e1c9bf2128409172f48b3ea1cd1ee5
Submitter: Jenkins
Branch: master
commit 8144e28336e1c9bf2128409172f48b3ea1cd1ee5
Author: Rodrigo Duarte Sousa <rduartes@xxxxxxxxxx>
Date: Fri Aug 19 11:54:57 2016 -0300
Fix credential update to ec2 type
It was possible to create a credential without providing a project_id
and later updating it to the ec2 type.
This patch fixes the issue by adding a manual checking in the
manager layer since it needs to check the old credential contents
prior failing the request.
Change-Id: I1eb28a46c89e17d9c990cc798867d1a59714fe5f
Closes-Bug: #1613466
** Changed in: keystone
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Identity (keystone).
https://bugs.launchpad.net/bugs/1613466
Title:
Update credential to "ec2" type accepts a credential without the
project set
Status in OpenStack Identity (keystone):
Fix Released
Bug description:
In the credentials API schema validation [1] is mandatory to include a
project when creating a credential of the "ec2" type, but we can
create a credential from a different type and update it to "ec2"
without providing a project [2].
[1] https://github.com/openstack/keystone/blob/master/keystone/credential/schema.py#L29-L55
[2] https://github.com/openstack/keystone/blob/master/keystone/credential/schema.py#L57-L62
To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1613466/+subscriptions
References