yahoo-eng-team team mailing list archive
-
yahoo-eng-team team
-
Mailing list archive
-
Message #55629
[Bug 1273730] Re: MechanismDriverError hides original exception
Reviewed: https://review.openstack.org/327500
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=8398ec0d771dd8e4944034ec2e658c747671de3e
Submitter: Jenkins
Branch: master
commit 8398ec0d771dd8e4944034ec2e658c747671de3e
Author: Hong Hui Xiao <honghui_xiao@xxxxxxxx>
Date: Sat Aug 20 09:06:10 2016 -0400
Add mechanism driver error details to MechanismDriverError
Now the ML2 core plugin maps driver errors to MechanismDriverError
and hides the error details from the caller.
This patch change MechanismDriverError from an instance of
NeutronException to an instance of MultipleExceptions. Add add
exceptions from mechanism driver as inner_exceptions of
MultipleExceptions. As a result, the api layer will unwrap the
MechanismDriverError and return the real error to client.
Change-Id: I3a46932848d59f7f027640bfb598650f064b0a12
Closes-bug: #1273730
** Changed in: neutron
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1273730
Title:
MechanismDriverError hides original exception
Status in neutron:
Fix Released
Bug description:
In implementing a mechanism driver for ML2, I see that any exceptions
raised by the mechanism driver are swallowed and all that's bubbled up
to the user is the generic MechanismDriverError. This happens in
MechanismManager_call_on_drivers() in
https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/managers.py.
It would be nice if the MechanismDriverError at least contained the
exception details from the last exception encountered in the driver
chain.
To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1273730/+subscriptions
References