yahoo-eng-team team mailing list archive

[OpenStack Infra <1609647@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/351046
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=eeed08e3edaf8ec08c56aaef1565746c4135b144
Submitter: Jenkins
Branch:    master

commit eeed08e3edaf8ec08c56aaef1565746c4135b144
Author: LIU Yulong <liuyulong@xxxxxx>
Date:   Thu Aug 4 14:54:32 2016 +0800

    Do not remove the HA/legacy router gateway secondary IPs
    
    When the HA/legacy router processing the floating IP, it will remove
    the gateway secondary IPs from the qg-device. This may cause exception
    after the a router gateway IP updating when L3 agent try to remove
    such router.
    
    This patch will let the qg-device keep the HA/legacy router gateway
    secondary IPs.
    
    Change-Id: I022253a84aee0ed6fecc2f74bed88160f38fa61e
    Closes-Bug: #1609647


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1609647

Title:
  HA/legacy router gateway secondary IPs were removed unexpectedly

Status in neutron:
  Fix Released

Bug description:
  HA/legacy router gateway secondary IPs was removed Unexpectedly.

  First it process the external gateway:
  https://github.com/openstack/neutron/blob/master/neutron/agent/l3/router_info.py#L1035
  https://github.com/openstack/neutron/blob/master/neutron/agent/l3/router_info.py#L817

  Then process the router floating IPs:
  https://github.com/openstack/neutron/blob/master/neutron/agent/l3/router_info.py#L828

  And then, the gateway secondary IPs has a /32 prefix, which will be treated as `fips_to_remove`:
  https://github.com/openstack/neutron/blob/master/neutron/agent/l3/router_info.py#L290

  Some related code:
  existing_cidrs = self.get_router_cidrs(device), this existing_cidrs including the gateway secondary IPs:
  https://github.com/openstack/neutron/blob/master/neutron/agent/l3/router_info.py#L304

  gateway secondary IPs were removed here:
  https://github.com/openstack/neutron/blob/master/neutron/agent/l3/router_info.py#L332

  
  DVR/DVR_SNAT_HA router does not have this issue.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1609647/+subscriptions