← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1617859] [NEW] A compatibility issue in the obj_make_compatible method of MonitorMetric object

 

Public bug reported:

In the obj_make_compatible method of MonitorMetric object, the
'numa_nodes_values' in 'if' statement should be 'numa_membw_values'

-------------------------------------------------------------------------------
class MonitorMetric(base.NovaObject):
(snipped...)
    def obj_make_compatible(self, primitive, target_version):
        super(MonitorMetric, self).obj_make_compatible(primitive,
                                                       target_version)
        target_version = versionutils.convert_version_to_tuple(target_version)
        if target_version < (1, 1) and 'numa_nodes_values' in primitive:
            del primitive['numa_membw_values']
-------------------------------------------------------------------------------

https://github.com/openstack/nova/blob/a5cc0be5c658974a4dd2b792e23c381fd8961e23/nova/objects/monitor_metric.py#L52

** Affects: nova
     Importance: Undecided
     Assignee: Takashi NATSUME (natsume-takashi)
         Status: In Progress

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1617859

Title:
  A compatibility issue in the obj_make_compatible method of
  MonitorMetric object

Status in OpenStack Compute (nova):
  In Progress

Bug description:
  In the obj_make_compatible method of MonitorMetric object, the
  'numa_nodes_values' in 'if' statement should be 'numa_membw_values'

  -------------------------------------------------------------------------------
  class MonitorMetric(base.NovaObject):
  (snipped...)
      def obj_make_compatible(self, primitive, target_version):
          super(MonitorMetric, self).obj_make_compatible(primitive,
                                                         target_version)
          target_version = versionutils.convert_version_to_tuple(target_version)
          if target_version < (1, 1) and 'numa_nodes_values' in primitive:
              del primitive['numa_membw_values']
  -------------------------------------------------------------------------------

  https://github.com/openstack/nova/blob/a5cc0be5c658974a4dd2b792e23c381fd8961e23/nova/objects/monitor_metric.py#L52

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1617859/+subscriptions


Follow ups