yahoo-eng-team team mailing list archive

[OpenStack Infra <1618216@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/362458
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=85ed7017ff22dd24ef7558010e62598483561354
Submitter: Jenkins
Branch:    master

commit 85ed7017ff22dd24ef7558010e62598483561354
Author: Kevin Benton <kevin@xxxxxxxxxx>
Date:   Sat Aug 27 05:03:54 2016 -0700

    Don't catch DBError in DHCP action handler
    
    The DHCP port action handler has been catching DBErrors
    since f1b9ac5a542a3125d757094fccda80c80c6dd420, which is
    well before we had the retry decorator to deal with these.
    With the port action handler catching these, it means there
    will not be retries on deadlocks or connection errors so
    transient situations can result in a permanently broken
    DHCP service for a network.
    
    This removes the catch for DBError so the decorator can retry
    the operation.
    
    Closes-Bug: #1618216
    Change-Id: I42031b481958bbfdb8f52902c294022717af7adf


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1618216

Title:
  dhcp agent RPC handler doesn't retry DBError

Status in neutron:
  Fix Released

Bug description:
  The RPC handler to create a port is catching DBError's before the
  retry decorator gets a chance to retry them. This ends up being
  treated like a broken network to the agent so the network will not
  have any DHCP service, leading to difficult to debug failures like
  this one:

  http://logs.openstack.org/82/346282/4/check/gate-tempest-dsvm-neutron-
  full-ubuntu-xenial/d4ea1f6/console.html

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1618216/+subscriptions