yahoo-eng-team team mailing list archive

[Tony Breeds <tony@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

With the release of os-brick 1.6.0 the following review[1] was created
to use it in upper-constraints.txt

This review is failing the nova[2] and cinder[3] unit tests

It's relatively simple to fix these problems to work with 1.6.0 but the
code needs to work with both 1.5.0 *and* 1.6.0.  This is where we have
problems.

The connector objects moved from
os_brick.initiator.connector.ISCSIConnector (1.5.0) to
os_brick.initiator.connectors.ISCSIConnector (1.6.0) so any tests need
shims in place to work with either name.  The shim could be removed once
global-requirements is bumped to use 1.6.0 as the minimum but it's very
late to be making that change as that'd cause a re-release of any
libraries (glance_store) using os-brick.


[1] https://review.openstack.org/#/c/360739/
[2] http://logs.openstack.org/39/360739/2/check/gate-cross-nova-python27-db-ubuntu-xenial/bb19321/console.html#_2016-08-31_02_20_59_089114
[3] http://logs.openstack.org/39/360739/2/check/gate-cross-cinder-python27-db-ubuntu-xenial/444b954/console.html#_2016-08-31_02_25_04_125200

** Affects: cinder
     Importance: Undecided
         Status: New

** Affects: nova
     Importance: Undecided
         Status: New

** Affects: os-brick
     Importance: Undecided
         Status: New

** Also affects: nova
   Importance: Undecided
       Status: New

** Also affects: cinder
   Importance: Undecided
       Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1618697

Title:
  os-brick 1.6.0 refactor was a major API change

Status in Cinder:
  New
Status in OpenStack Compute (nova):
  New
Status in os-brick:
  New

Bug description:
  With the release of os-brick 1.6.0 the following review[1] was created
  to use it in upper-constraints.txt

  This review is failing the nova[2] and cinder[3] unit tests

  It's relatively simple to fix these problems to work with 1.6.0 but
  the code needs to work with both 1.5.0 *and* 1.6.0.  This is where we
  have problems.

  The connector objects moved from
  os_brick.initiator.connector.ISCSIConnector (1.5.0) to
  os_brick.initiator.connectors.ISCSIConnector (1.6.0) so any tests need
  shims in place to work with either name.  The shim could be removed
  once global-requirements is bumped to use 1.6.0 as the minimum but
  it's very late to be making that change as that'd cause a re-release
  of any libraries (glance_store) using os-brick.


  
  [1] https://review.openstack.org/#/c/360739/
  [2] http://logs.openstack.org/39/360739/2/check/gate-cross-nova-python27-db-ubuntu-xenial/bb19321/console.html#_2016-08-31_02_20_59_089114
  [3] http://logs.openstack.org/39/360739/2/check/gate-cross-cinder-python27-db-ubuntu-xenial/444b954/console.html#_2016-08-31_02_25_04_125200

To manage notifications about this bug go to:
https://bugs.launchpad.net/cinder/+bug/1618697/+subscriptions