← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1611964] Re: SNAT redirect rules should be removed only on Gateway clear.

 

Reviewed:  https://review.openstack.org/353788
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=82c134d6e06fb47ffc923880ed597bddb7a06013
Submitter: Jenkins
Branch:    master

commit 82c134d6e06fb47ffc923880ed597bddb7a06013
Author: Swaminathan Vasudevan <swaminathan.vasudevan@xxxxxxx>
Date:   Wed Aug 10 13:48:19 2016 -0700

    DVR: SNAT redirect rules should be removed only on Gateway clear
    
    SNAT redirect rules should be removed only on gateway clear and
    not on gateway move or gateway reschedule to a different agent.
    This would make the snat node unreachable by the dvr service
    ports.
    
    Change-Id: Icec7eabfd06825bf3b4c48f06cf5b88e0a5af06d
    Closes-Bug: #1611964


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1611964

Title:
  SNAT redirect rules should be removed only on Gateway clear.

Status in neutron:
  Fix Released

Bug description:
  SNAT redirect rules should be removed only on Gateway clear and not for a gateway move or gateway reschedule.
  This would cause the snat_node unreachable by the dvr service ports on the originating node.

  How to reproduce it.

  1. Create a two network node setup (dvr_snat)
  2. Create a network
  3. Create a subnet
  4. Create a router and attach the subnet to the router.
  5. Set gateway to the router.
  6. Now try to reschedule the router to the secondary node or do a manaul move to a second node.
  7. In this case the 'external_gateway_removed" is called through 'external_gateway_updated' function and tries to call snat_redirect_remove.

  8. After you move the snat, the router namespace will not have the routing rule for the 'csnat' port.
  9. It clears up and you only see the base rules.

  Expected:
  root@ubuntu-ctlr:~/devstack# ip rule
  0:	from all lookup local 
  32766:	from all lookup main 
  32767:	from all lookup default 
  167772161:	from 10.0.0.1/24 lookup 167772161 
  root@ubuntu-ctlr:~/devstack# ip route s t 167772161
  default via 10.0.0.9 dev qr-18deeb39-3b 

  But Actual:
  root@ubuntu-ctlr:~/devstack# ip rule
  0:	from all lookup local 
  32766:	from all lookup main 
  32767:	from all lookup default

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1611964/+subscriptions


References