← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1421287] Re: [UI] Remove css from templates

 

Reviewed:  https://review.openstack.org/362033
Committed: https://git.openstack.org/cgit/openstack/sahara-dashboard/commit/?id=2b900b5a93cd3269e9a098249beb05986d6e32cf
Submitter: Jenkins
Branch:    master

commit 2b900b5a93cd3269e9a098249beb05986d6e32cf
Author: Mikhail Lelyakin <mlelyakin@xxxxxxxxxxxx>
Date:   Thu Sep 1 14:05:29 2016 +0300

    Remove css styles from html templates
    
    Changes:
      1. Remove css styles from html templates.
      2. Transfer this styles to new css files.
    
    Change-Id: I318b5fb4a6f15456d7756bc438e0d93b91255203
    Closes-bug: 1421287


** Changed in: sahara
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1421287

Title:
  [UI] Remove css from templates

Status in OpenStack Dashboard (Horizon):
  Invalid
Status in Sahara:
  Fix Released

Bug description:
  * low priority, technical debt item *

  There are a couple places in the Data Processing panels where there is
  css defined inside of the templates.  Ideally, existing css rules can
  be applied to achieve the desired results, but it is possible that we
  may need to add new styles to the projects css definitions.

  The places where css is defined in data processing templates are:
  .../horizon/openstack_dashboard/dashboards/project/data_processing/job_binaries/templates/data_processing.job_binaries/job_binaries.html

  <style type="text/css">
    #id_job_binary_url {
      width: 200px !important; }
    .form-help-block {
      float: left;
      text-align: left;
      width: 300px; }
  </style>

  and

  .../horizon/openstack_dashboard/dashboards/project/data_processing/jobs/templates/data_processing.jobs/jobs.html

  <style type="text/css">
      .job_origin_main, .job_origin_lib {
      width: 200px !important; }
      .job_binary_add_button, .job_binary_remove_button {
      width: 80px !important;
      margin-left: 5px; }
      .form-help-block {
      float: left;
      text-align: left;
      width: 300px; }
      .lib-input-div {
      float:left;
      width:320px; }
      .job-libs-display {
      float:left; }
      .actions_column {
      width: 210px !important; }
  </style>

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1421287/+subscriptions


References