yahoo-eng-team team mailing list archive

[OpenStack Infra <1339855@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/365196
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=5a49379b349dc33f403cfdcfd6148dfa362512de
Submitter: Jenkins
Branch:    master

commit 5a49379b349dc33f403cfdcfd6148dfa362512de
Author: Ji-Wei <ji.wei3@xxxxxxxxxx>
Date:   Sat Sep 3 13:03:13 2016 +0800

    Raise NotImplementedError instead of NotImplemented
    
    NotImplementedError is the name of the exception
    (https://docs.python.org/2/library/exceptions.html).
    NotImplemented is the name of a constant
    (https://docs.python.org/2/library/constants.html).
    >>> raise NotImplemented()
    Traceback (most recent call last):
      File "<pyshell#31>", line 1, in <module>
        raise NotImplemented()
    TypeError: 'NotImplementedType' object is not callable
    >>> raise NotImplementedError()
    Traceback (most recent call last):
      File "<pyshell#32>", line 1, in <module>
        raise NotImplementedError()
    NotImplementedError
    
    This patch fix it.
    
    Change-Id: I36292e5ee18bd792205a8ff527f4ae9705c61b61
    Closes-Bug: #1339855


** Changed in: keystone
       Status: New => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1339855

Title:
  Raise NotImplementedError instead of NotImplemented

Status in CloudCafe:
  Fix Committed
Status in Fuel for OpenStack:
  Fix Committed
Status in OpenStack Identity (keystone):
  Fix Released
Status in keystonemiddleware:
  New
Status in neutron:
  Fix Released
Status in Solar:
  New
Status in Warm:
  Invalid

Bug description:
  NotImplementedError is the name of the exception
  (https://docs.python.org/2/library/exceptions.html).

  NotImplemented is the name of a constant
  (https://docs.python.org/2/library/constants.html).

  It makes no sense to raise a constant. The exception should be raised
  instead.

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloudcafe/+bug/1339855/+subscriptions