yahoo-eng-team team mailing list archive

[OpenStack Infra <1619690@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/365015
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=345febe3216a9cb3eb16194c8df981a116a4f9d8
Submitter: Jenkins
Branch:    master

commit 345febe3216a9cb3eb16194c8df981a116a4f9d8
Author: Chris Dent <cdent@xxxxxxxxxxxxx>
Date:   Fri Sep 2 14:39:31 2016 +0000

    Move placement api request logging to middleware
    
    This change moves the request logging in the placement api to
    middleware that is the outermost piece of middleware in the system.
    
    Without this we end up with a situation where some requests which
    are not successful appear to be logged with success and other
    request do not get logged at all.
    
    By using middleware we assure that the logging of the beginning of
    the request and _any_ exit of the request will be logged because the
    middleware can be the first and last thing the request interacts
    with.
    
    Change-Id: I4215cc69cedae5637102b75e0b54fd26acb1826c
    Closes-Bug: #1619690


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1619690

Title:
  request logging in placement api always logs success

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  The request logging in the placement api will always log a status of
  200, even when that's not the case because it it getting status from
  the wrong place. A possible fix is to raise the logging up a level to
  middleware where it can access the response status more directly
  (after exceptions).

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1619690/+subscriptions