← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1620722] [NEW] @property methods in Managers are cached

 

Public bug reported:

When working on the credential encryption spec, I found that one of the
@property methods in the implementation was having it's value cached.
Typical @property methods should be run every time they are called. This
was not the case in the credential encryption implementation because we
override the __getattr__ method in our base Manager class [0].

We should modify that method so that @property methods can be used when
inheriting from the common Manager.

[0]
https://github.com/openstack/keystone/blob/b47f10290ed83415149f3d2ab6b0dc64646e578a/keystone/common/manager.py#L185-L189

** Affects: keystone
     Importance: Undecided
     Assignee: David Stanek (dstanek)
         Status: In Progress

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Identity (keystone).
https://bugs.launchpad.net/bugs/1620722

Title:
  @property methods in Managers are cached

Status in OpenStack Identity (keystone):
  In Progress

Bug description:
  When working on the credential encryption spec, I found that one of
  the @property methods in the implementation was having it's value
  cached. Typical @property methods should be run every time they are
  called. This was not the case in the credential encryption
  implementation because we override the __getattr__ method in our base
  Manager class [0].

  We should modify that method so that @property methods can be used
  when inheriting from the common Manager.

  [0]
  https://github.com/openstack/keystone/blob/b47f10290ed83415149f3d2ab6b0dc64646e578a/keystone/common/manager.py#L185-L189

To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1620722/+subscriptions


Follow ups