← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1614538] Re: neutron: instance.info_cache isn't refreshed after deleting associated floating IP

 

Reviewed:  https://review.openstack.org/357494
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=cdb9b6820dc17971bca24adfc0b56f030f0ae827
Submitter: Jenkins
Branch:    master

commit cdb9b6820dc17971bca24adfc0b56f030f0ae827
Author: Michael Wurtz <michael.wurtz@xxxxxxx>
Date:   Thu Aug 18 14:53:33 2016 -0500

    Refresh info_cache after deleting floating IP
    
    When deleting a floating IP associated with Neutron's info_cache we don't
    refresh the info_cache after it is deleted.
    This patch makes it so the info_cache is refreshed when an associated
    floating IP is deleted. If there is no info_cache associated with the
    floating IP then info_cache is not refreshed.
    
    Change-Id: I8a8ae8cdbe2d9d77e7f1ae94ebdf6e4ad46eaf00
    Closes-Bug:  #1614538


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1614538

Title:
  neutron: instance.info_cache isn't refreshed after deleting associated
  floating IP

Status in OpenStack Compute (nova):
  Fix Released
Status in OpenStack Compute (nova) liberty series:
  In Progress
Status in OpenStack Compute (nova) mitaka series:
  Confirmed

Bug description:
  Shown in a tempest test here:

  http://logs.openstack.org/95/356095/2/check/gate-tempest-dsvm-neutron-
  full-ubuntu-xenial/8d3cbb2/console.html#_2016-08-18_03_18_38_290951

  You can see from this patch that we refresh the instance's network
  info_cache (server.addresses) when deleting a floating IP associated
  with that instance but only when using nova-network, we don't do it
  for neutron.

  This is related to bug 1586931 and investigation that happened in
  https://review.openstack.org/#/c/351960/.

  Basically the problem is that this method isn't decorated with the
  refresh_cache decorator:

  https://github.com/openstack/nova/blob/d14fc79f65e04cc39a3988783344aecd84621291/nova/network/neutronv2/api.py#L1826

  But notice that this is:

  https://github.com/openstack/nova/blob/d14fc79f65e04cc39a3988783344aecd84621291/nova/network/neutronv2/api.py#L1845

  That's the method that's called from the REST API when disassociating,
  but not deleting, a floating IP from a server.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1614538/+subscriptions


References