yahoo-eng-team team mailing list archive

[OpenStack Infra <1612222@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/354011
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=5d597367cfc89267793db0e861aa885044ac8f71
Submitter: Jenkins
Branch:    master

commit 5d597367cfc89267793db0e861aa885044ac8f71
Author: Kevin Benton <kevin@xxxxxxxxxx>
Date:   Thu Aug 11 02:02:59 2016 -0700

    Except if tracked resource registered as countable
    
    If a resource was registered in the quota engine before
    being set as a tracked resource, it would have been registered
    as a CountableResource instead of a TrackedResource.
    
    This would cause a failure later when the resources were
    being unregistered because the quota engine thought it
    should have been a TrackedResource and tried to call
    unregister_events on it.
    
    This patch just prevents resources from being registered
    as both types. It also callse unregister_all_resources as
    part of the standard test case cleanup since the vast majority
    of tests are using a plugin that may register resources.
    
    Closes-Bug: #1612222
    Change-Id: I8a40f38d7c0e5aeca257ba62115fa9b02ad5aa93


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1612222

Title:
  quota unit test failure

Status in neutron:
  Fix Released

Bug description:
  spotted failure in a unit test unrelated to the patch. appears to be a
  result of leaked resources between the tests.

  ===
  FAIL: neutron.tests.unit.quota.test_resource_registry.TestAuxiliary
  Functions.test_set_resources_dirty
  tags: worker-0
  -------------------------------------------------------------------
  ---
  Empty attachments:
    pythonlogging:''
    stderr
    stdout

  Traceback (most recent call last):
    File "neutron/tests/unit/quota/test_resource_registry.py", line 9
  0, in setUp
      self.registry.unregister_resources()
    File "neutron/quota/resource_registry.py", line 239, in unregiste
  r_resources
      res.unregister_events()
  AttributeError: 'CountableResource' object has no attribute 'unregi
  ster_events'

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1612222/+subscriptions