← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1620445] Re: Correct PERF_EVENTS_CPU_FLAG_MAPPING due to libvirt changes

 

Reviewed:  https://review.openstack.org/365842
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=a2d0b8d1b0954c6fdc622dda8fe8777e41566d92
Submitter: Jenkins
Branch:    master

commit a2d0b8d1b0954c6fdc622dda8fe8777e41566d92
Author: Eli Qiao <liyong.qiao@xxxxxxxxx>
Date:   Tue Sep 6 11:51:29 2016 +0800

    Libvirt: Correct PERF_EVENTS_CPU_FLAG_MAPPING
    
    History:
    
    libvirt 1.3.3 had added perf event support for cmt, mbmt, mbml support
    when we landing the spec
    https://blueprints.launchpad.net/nova/+spec/support-perf-event .
    
    For the event cmt, mbmt, mbml, we requires that libvirt to expose some
    some specify cpu features, but libvirt 2.0.0 only has that expose merged
    `cpu_map.xml: add cmt/mbm feature to x86 (Qiaowei Ren)`, the capabilities
    changed to:
    
    <feature name='mbm_total'/>
    <feature name='mbm_local'/>
    <feature name='cmt'/>
    
    Need to adopt this to let nova driver discover these features when
    enable cmt, mbmt, mbml event.
    
    That is to say: even libvirt 1.3.3 has support perf event, but nova
    cannot get noticed since libvirt don't expose cpu features until 2.0.0.
    
    This patch bump MIN_LIBVIRT_PERF_VERSION to 2.0.0, see:
    https://libvirt.org/formatdomain.html#elementsPerf
    
    Closes-Bug: #1620445
    Change-Id: Ie896cfd478f4528903ca5dd56c61680837b646b7


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1620445

Title:
  Correct PERF_EVENTS_CPU_FLAG_MAPPING due to libvirt changes

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  Libvirt 2.0.0 has merge cpu_map.xml: add cmt/mbm feature to x86
  (Qiaowei Ren), but the capabilities are:

  <feature name='mbm_total'/>
  <feature name='mbm_local'/> 
  <feature name='cmt'/>

  Need to adopt this in nova code.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1620445/+subscriptions


References