yahoo-eng-team team mailing list archive

[OpenStack Infra <1616222@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/359437
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=a988f3c457fca8cd990eec507638cf0dcc0c5011
Submitter: Jenkins
Branch:    master

commit a988f3c457fca8cd990eec507638cf0dcc0c5011
Author: Ryan Peters <rjpeter2@xxxxxxxxx>
Date:   Tue Aug 23 16:27:26 2016 -0500

    All Table Templates should support template overrides
    
    Overrides were not possible on some templates due to
    not reading from the "options" array while assigning
    values in the DataTableOptions class.
    
    Change-Id: Ia0905cbf772445c39006d10a5a040b5244587914
    Closes-bug: #1616222


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1616222

Title:
  All Table Templates should support template overrides

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  Only some of the table templates are overridable through the meta
  DataTableOptions class.  They would ALL be overrideable.

          self.template = getattr(options,
                                  'template',
                                  'horizon/common/_data_table.html')

  The other templates, listed below, should also use the 'getattr'
  option.

          self.row_actions_dropdown_template = ('horizon/common/_data_table_'
                                                'row_actions_dropdown.html')
          self.row_actions_row_template = ('horizon/common/_data_table_'
                                           'row_actions_row.html')
          self.table_actions_template = \
              'horizon/common/_data_table_table_actions.html'

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1616222/+subscriptions