yahoo-eng-team team mailing list archive
-
yahoo-eng-team team
-
Mailing list archive
-
Message #56220
[Bug 1578500] Re: Nova 'ComputeManager._build_and_run_instance' method sends inappropriate notification ('create.end')
Reviewed: https://review.openstack.org/312887
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=19cc6e2ca897e65a630dfb3905ca62e8101d5b2e
Submitter: Jenkins
Branch: master
commit 19cc6e2ca897e65a630dfb3905ca62e8101d5b2e
Author: Rajesh Tailor <ratailor@xxxxxxxxxx>
Date: Thu May 5 06:11:25 2016 -0400
Fix inappropriate notification send
The method '_build_and_run_instance' sends inappropriate
notification 'create.end' when an exception is raised, instead
it should be sending 'create.error' notification.
Replaced 'create.end' notification with 'create.error'
when exception is raised.
Change-Id: I2661cc47b6ebb674cce2f2b43851aa9eca12b5f8
Closes-Bug:1578500
** Changed in: nova
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1578500
Title:
Nova 'ComputeManager._build_and_run_instance' method sends
inappropriate notification ('create.end')
Status in OpenStack Compute (nova):
Fix Released
Bug description:
In Nova 'ComputeManager._build_and_run_instance' method, if
InstanceNotFound or UnexpectedDeletingTaskStateError raises,
'compute.instance.create.end' notification will be sent[1]. It would
be more reasonable if we send 'compute.instance.create.error'
notification instead.
[1]https://github.com/openstack/nova/blob/13.0.0.0rc3/nova/compute/manager.py#L2072
To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1578500/+subscriptions
References