yahoo-eng-team team mailing list archive

[Tyr Johanson <tyr@xxxxxx>]

Public bug reported:

Angular widgets that listen for or dispatch events have the possibility
of accidentally picking up the wrong event unless the event string is
unique.

For example, see
https://review.openstack.org/#/c/321132/8/horizon/static/framework/widgets
/magic-search/magic-search.module.js

"textSearch" is fairly generic, and might collide with another component
accidentally.

Consider instead including the module name as part of the event string.

For example: "horizon.framework.widgets.magic-search.events.textSearch"

** Affects: horizon
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1622698

Title:
  Use unique names for event strings

Status in OpenStack Dashboard (Horizon):
  New

Bug description:
  Angular widgets that listen for or dispatch events have the
  possibility of accidentally picking up the wrong event unless the
  event string is unique.

  For example, see
  https://review.openstack.org/#/c/321132/8/horizon/static/framework/widgets
  /magic-search/magic-search.module.js

  "textSearch" is fairly generic, and might collide with another
  component accidentally.

  Consider instead including the module name as part of the event
  string.

  For example: "horizon.framework.widgets.magic-
  search.events.textSearch"

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1622698/+subscriptions