← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1622632] Re: Circular dependency in neutron.services.trunk.utils

 

Reviewed:  https://review.openstack.org/368882
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=68d13b92a51b73b158b2446366e67233cc4279d5
Submitter: Jenkins
Branch:    master

commit 68d13b92a51b73b158b2446366e67233cc4279d5
Author: Jakub Libosvar <libosvar@xxxxxxxxxx>
Date:   Mon Sep 12 16:37:37 2016 +0200

    trunk: Remove ovs constants from trunk utils module
    
    Trunk utils should be driver agnostic.
    
    Change-Id: Iec646b3b11b03687013db5af6afda3a21c03acb6
    Closes-Bug: 1622632


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1622632

Title:
  Circular dependency in neutron.services.trunk.utils

Status in neutron:
  Fix Released

Bug description:
  There is a circular dependency when importing
  neutron.services.trunk.utils:

  In [1]: from neutron.services.trunk import utils
  ---------------------------------------------------------------------------
  ImportError                               Traceback (most recent call last)
  <ipython-input-1-ea7d6178c9bc> in <module>()
  ----> 1 from neutron.services.trunk import utils

  /opt/stack/neutron/neutron/services/trunk/utils.py in <module>()
       17 from neutron.common import utils
       18 from neutron import manager
  ---> 19 from neutron.services.trunk.drivers.openvswitch import constants as ovs_const
       20
       21

  /opt/stack/neutron/neutron/services/trunk/drivers/__init__.py in <module>()
       15
       16 from neutron.services.trunk.drivers.linuxbridge import driver as lxb_driver
  ---> 17 from neutron.services.trunk.drivers.openvswitch import driver as ovs_driver
       18
       19

  /opt/stack/neutron/neutron/services/trunk/drivers/openvswitch/driver.py in <module>()
       23 from neutron.services.trunk import constants as trunk_consts
       24 from neutron.services.trunk.drivers import base
  ---> 25 from neutron.services.trunk import utils
       26
       27 LOG = logging.getLogger(__name__)

  ImportError: cannot import name utils

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1622632/+subscriptions


References