← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1623183] Re: [FWaaS] project_id being returned instead of tenant_id by neutron, breaking some FWaaS unit tests

 

Reviewed:  https://review.openstack.org/369537
Committed: https://git.openstack.org/cgit/openstack/neutron-fwaas/commit/?id=1da6c2fd1af57046edf45d9c65d5885a116131e4
Submitter: Jenkins
Branch:    master

commit 1da6c2fd1af57046edf45d9c65d5885a116131e4
Author: Nate Johnston <nate_johnston@xxxxxxxxxxxxxxxxx>
Date:   Tue Sep 13 15:32:38 2016 +0000

    Fix neutron-fwaas tests after project_id addition
    
    All dicts being returned from API calls that included tenant_id now also
    include project_id.  In places where the entire response dict was
    constructed for construction, add project_id in addition to tenant_id.
    
    Closes-Bug: #1623183
    
    Change-Id: I2dda5960c6212150f0e5427678e39e5604830718


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1623183

Title:
  [FWaaS] project_id being returned instead of tenant_id by neutron,
  breaking some FWaaS unit tests

Status in neutron:
  Fix Released

Bug description:
  With project_id now being accepted and returned systematically in
  Neutron[1], some of the FWaaS unit tests have broken.  This has broken
  the FWaaS gate.  There are a couple of reasons why they have broken:

  1. They are giving a bad tenant_id and are looking for an exception to
  be thrown with error text 'Invalid input for tenant_id', but now this
  is coming back as 'Invalid input for project_id'.

  2. In some cases dicts are being constructed to represent the expected
  response to the API call, and these include 'tenant_id'.  These are
  then compared to the response, and the response includes both
  'tenant_id' and 'project_id'.

  [1]
  http://git.openstack.org/cgit/openstack/neutron/commit/?id=ba788da398b31d5433a91bdc72ff2695b475fa41

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1623183/+subscriptions


References