← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1621345] Re: dhcp notifier should use core resource events

 

Reviewed:  https://review.openstack.org/355117
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=181bdb374fc0c944b1168f27ac7b5cbb0ff0f3c3
Submitter: Jenkins
Branch:    master

commit 181bdb374fc0c944b1168f27ac7b5cbb0ff0f3c3
Author: Kevin Benton <kevin@xxxxxxxxxx>
Date:   Fri Aug 12 05:26:39 2016 -0700

    Make DHCP notifier use core resource events
    
    This makes the notifier subscribe to core resource events
    and leverage them if they are available. This solves the
    issue where internal core plugin calls from service plugins
    were not generating DHCP agent notifications.
    
    Closes-Bug: #1621345
    Change-Id: I607635601caff0322fd0c80c9023f5c4f663ca25


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1621345

Title:
  dhcp notifier should use core resource events

Status in neutron:
  Fix Released

Bug description:
  The current DHCP notifier only tells the DHCP agents things when
  ports/subnets/networks are modified via the Neutron API. This is
  problematic because service plugins may modify ports directly via the
  core plugin API, which results in the agents not being notified unless
  special care is taken to make modifications via utility functions that
  emit API events[1]. This leaves too much room for subtle
  inconsistencies between the data model and the DHCP agent. The DHCP
  notifier should just subscribe directly to the callbacks for
  networks/subnets/ports.


  1.
  https://github.com/openstack/neutron/blob/dc6508aae2819f2b718785b4da2c11f30bdc3ffd/neutron/plugins/common/utils.py#L175-L183

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1621345/+subscriptions


References