← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1619771] Re: in placement api format of GET .../inventories does not match spec

 

Reviewed:  https://review.openstack.org/365633
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=b221f11ee00fbf8b8a8c2b8e9ec9d761da2628b1
Submitter: Jenkins
Branch:    master

commit b221f11ee00fbf8b8a8c2b8e9ec9d761da2628b1
Author: Chris Dent <cdent@xxxxxxxxxxxxx>
Date:   Mon Sep 5 12:11:04 2016 +0000

    [placement] Correct serialization of inventory collections
    
    The correct form is for resource_provider_generation to be its on
    separate key, not repeated in each individual inventory. This was
    probably caused by the refactoring that create _send_inventory and
    _send_inventories and a lack of sufficient test coverage.
    
    Fixing this involves changes in both the placement api service, and
    in the (thus far) only existing client, the scheduler reporting
    client used in the resource tracker. The reporting client can be a
    bit simpler now because of the cleaner behavior in the api.
    
    Tests have been updated accordingly.
    
    Change-Id: I3af1c7686a45c1a0d70fe704d3c7938810eff6a3
    Closes-Bug: #1619771


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1619771

Title:
  in placement api format of GET .../inventories does not match spec

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  The correct format is described at
  http://specs.openstack.org/openstack/nova-specs/specs/newton/approved
  /generic-resource-pools.html#get-resource-providers-uuid-inventories

  In that format the resource provider generation is its own top level
  key.

  In the code the generation is repeated per resource class which means
  we cannot retrieve the resource provider without first inspecting an
  inventory.

  We should fix this sooner than later so that we have a simpler
  resource tracker.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1619771/+subscriptions


References