yahoo-eng-team team mailing list archive

[OpenStack Infra <1623738@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/290919
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=0683fcd3f551dc55438d9f8415b8931f22635bd5
Submitter: Jenkins
Branch:    master

commit 0683fcd3f551dc55438d9f8415b8931f22635bd5
Author: Giridhar Jayavelu <gjayavelu@xxxxxxxxxx>
Date:   Wed Mar 9 14:10:49 2016 -0800

    Handle TypeError when disabling host service
    
    When _set_host_enabled() in virt/libvirt/driver.py
    is called to change service status of a host from
    enabled to disabled without providing disable_reason, then
    a TypeError occurs while concatenating disabled_reason with
    DISABLE_PREFIX. This prevents the service status of the host
    from being updated.
    
    This patch handles the case when disable_reason is None.
    Also, unit tests have been fixed to validate the code path for
    changing the disabled state of a host.
    
    Closes-Bug: #1623738
    Change-Id: Ib131f73444234723ef8bbb15bb4bd4a62a83320d


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1623738

Title:
  Disabled state of host is not updated when reason is not provided.

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  When _set_host_enabled() in virt/libvirt/driver.py
  is called to disable service status of a host without
  providing disabled_reason, then "TypeError: cannot concatenate 'str' and
  'NoneType' objects" is raised. This prevents the disabled state getting updated.

  Before concatenating disable_reason with DISABLE_PREFIX, 
  disabled_reason should be checked if it is defined or not.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1623738/+subscriptions