yahoo-eng-team team mailing list archive

[Drew Thorstensen <thorst@xxxxxxxxxx>]

Public bug reported:

This change recently went in to the neutron hacking checks:

https://github.com/openstack/neutron/commit/31e1aeb66b2d8abb0d8424e9550693fad6f37c1c

While this serves the purpose of not allowing functional tests from
within neturon to extend unit test functions, it blocks out of tree
neutron drivers/ml2 agents from importing the neutron unit tests within
their own unit tests.

Out of tree drivers/ml2 agents are no longer able to run the hacking
checks that they extend from neutron against their own source tree - or
they have to explicitly exclude the check_no_imports_from_tests rule.


Neutron Code: https://github.com/openstack/neutron/blame/master/neutron/hacking/checks.py#L390-L403

Example of broken check (PowerVM): https://github.com/openstack
/networking-powervm/blob/master/networking_powervm/hacking/checks.py#L45

** Affects: networking-powervm
     Importance: Undecided
         Status: New

** Affects: neutron
     Importance: Undecided
         Status: New

** Also affects: neutron
   Importance: Undecided
       Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1626298

Title:
  Out of tree drivers fail to run hacking checks now

Status in networking-powervm:
  New
Status in neutron:
  New

Bug description:
  This change recently went in to the neutron hacking checks:

  https://github.com/openstack/neutron/commit/31e1aeb66b2d8abb0d8424e9550693fad6f37c1c

  While this serves the purpose of not allowing functional tests from
  within neturon to extend unit test functions, it blocks out of tree
  neutron drivers/ml2 agents from importing the neutron unit tests
  within their own unit tests.

  Out of tree drivers/ml2 agents are no longer able to run the hacking
  checks that they extend from neutron against their own source tree -
  or they have to explicitly exclude the check_no_imports_from_tests
  rule.

  
  Neutron Code: https://github.com/openstack/neutron/blame/master/neutron/hacking/checks.py#L390-L403

  Example of broken check (PowerVM): https://github.com/openstack
  /networking-
  powervm/blob/master/networking_powervm/hacking/checks.py#L45

To manage notifications about this bug go to:
https://bugs.launchpad.net/networking-powervm/+bug/1626298/+subscriptions