yahoo-eng-team team mailing list archive

[OpenStack Infra <1620748@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/373380
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=995d283e4f9a6a0cbf44f840c643d7dd99212f82
Submitter: Jenkins
Branch:    master

commit 995d283e4f9a6a0cbf44f840c643d7dd99212f82
Author: Chris Dent <cdent@xxxxxxxxxxxxx>
Date:   Tue Sep 20 14:36:37 2016 +0000

    [placement] Stringify class and provider uuid in error
    
    When attempting to make an allocation of a particular class of
    resource against a resource provider which has no inventory for that
    class, an InvalidInventory exception is raised. This was workign
    okay but the associated message was displaying stringified sets
    of resource class ids, and not the resource classes names.
    
    This changes joins the sets into strings for both resource classes
    and provider uuids and turns the class indexes into their names.
    A functional test which was checking for the exception has been
    updated to also check the exception's message.
    
    Change-Id: Ife38220da1069ffb6da26a4f8e3b954f0dc12f13
    Closes-Bug: #1620748


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1620748

Title:
  In placement when an attempt is made to write to missing inventory the
  error message is ugly

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  The error message from the exception is:

      Inventory for 'set([0, 2])' on resource provider 'set(['a7774b97
  -838c-4b36-9cda-cfe6cbba0f0f'])' invalid

  This is because the data given to the exception has not been
  stringified from sets nor turned from resource class ids to resource
  class strings. Change needed near here:

  https://github.com/openstack/nova/blob/985c7ca4dc15176dc9cccf0ebcabaa18ea98ca2a/nova/objects/resource_provider.py#L715

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1620748/+subscriptions