yahoo-eng-team team mailing list archive
-
yahoo-eng-team team
-
Mailing list archive
-
Message #56962
[Bug 1302831] Re: hacking/flake8 skips most xenapi plugins
Reviewed: https://review.openstack.org/289431
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=6bb1fd776feb7efd36a8c622ded37b67a21754cc
Submitter: Jenkins
Branch: master
commit 6bb1fd776feb7efd36a8c622ded37b67a21754cc
Author: Stephen Finucane <stephen.finucane@xxxxxxxxx>
Date: Mon Mar 7 16:12:17 2016 +0000
plugins/xenserver: Add '.py' extension
All Python files, except executables, should have a '.py' extension.
This wasn't being done for files in the 'plugins/xenserver' folder,
likely because it seems unnatural to call a "plugin" with a file
extension.
Begin working towards a resolution for this by renaming all files to
include a '.py' extension. To avoid forcing operators to upgrade the
Nova service and per-host plugins at the same time, continue to
reference the old, non-'.py' filenames, using symlinks to ensure the
references continue to work. Once Ocata has been released, these
symlinks can be removed, the API version updated and the reference
updated to include the '.py' extension.
Change-Id: Icf4cf2424c15276a6c01778fb92f76bbdc9b2068
Closes-bug: #1302831
** Changed in: nova
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1302831
Title:
hacking/flake8 skips most xenapi plugins
Status in OpenStack Compute (nova):
Fix Released
Bug description:
It appears to be because the plugins themselves don't have a filename
that ends in .py so they get skipped. Only the few files in there that
end .py are being checked.
To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1302831/+subscriptions
References