yahoo-eng-team team mailing list archive

[OpenStack Infra <1625981@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/373582
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=cb79d09e249a47d362706b2f4d64bd58c97c344f
Submitter: Jenkins
Branch:    master

commit cb79d09e249a47d362706b2f4d64bd58c97c344f
Author: Kevin Benton <kevin@xxxxxxxxxx>
Date:   Mon Sep 19 20:05:25 2016 -0700

    Fix ML2 revision_number handling in port updates
    
    The revision number is bumped on the flush that changes
    the port or a resource that bumps the port. However, in ML2
    we create the dict that is used for after_update events,
    mech driver calls, and the API response before all resource
    modifications are complete so the dict may not reflect
    the correct revision number.
    
    This adjusts the update_port_status to flush changes to the
    DB before constructing the dictionary response to give the
    event listener a chance to bump the revision.
    
    It also adjusts ML2 to update the 'updated_port' dict with
    the latest result from make_port_dict after all of the related
    objects have been processed to ensure the result has the latest
    info from extensions. The API test for allowed address pairs
    was adjusted to stop checking for order on update since no order
    is stored in the DB.
    
    The API test for revision numbers and ports was updated to
    expect the correct behavior.
    
    Closes-Bug: #1625981
    Change-Id: I49d2d79a57d484fd98b8969f511895e607b7f128


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1625981

Title:
  update response of ML2 doesn't include bumped revision number

Status in neutron:
  Fix Released

Bug description:
  Any operations the bump the revision number of the port that don't
  happen in the base_db_plugin update_port method don't reflect the
  increased revision number in the API response, mech driver
  pre/postcommit operations, or the registry events. This is because ML2
  calls make_port_dict before performing any of the additional port-
  related operations that might increase the revision number (changing
  security groups, etc).

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1625981/+subscriptions