← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1339855] Re: Raise NotImplementedError instead of NotImplemented

 

Reviewed:  https://review.openstack.org/365509
Committed: https://git.openstack.org/cgit/openstack/keystonemiddleware/commit/?id=f2792d7d07adb18a9fe676f28e589ebac6ed61a1
Submitter: Jenkins
Branch:    master

commit f2792d7d07adb18a9fe676f28e589ebac6ed61a1
Author: Ji-Wei <ji.wei3@xxxxxxxxxx>
Date:   Mon Sep 5 18:10:12 2016 +0800

    Raise NotImplementedError instead of NotImplemented
    
    NotImplementedError is the name of the exception
    (https://docs.python.org/2/library/exceptions.html).
    NotImplemented is the name of a constant
    (https://docs.python.org/2/library/constants.html).
    This patch fix it.
    
    Change-Id: If0c220b8fc8480e5904400e9086935944bce728a
    Closes-Bug: #1339855


** Changed in: keystonemiddleware
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1339855

Title:
  Raise NotImplementedError instead of NotImplemented

Status in CloudCafe:
  Fix Committed
Status in Fuel for OpenStack:
  Fix Committed
Status in heat:
  Fix Released
Status in OpenStack Identity (keystone):
  Fix Released
Status in keystonemiddleware:
  Fix Released
Status in neutron:
  Fix Released
Status in Solar:
  In Progress
Status in Warm:
  Invalid

Bug description:
  NotImplementedError is the name of the exception
  (https://docs.python.org/2/library/exceptions.html).

  NotImplemented is the name of a constant
  (https://docs.python.org/2/library/constants.html).

  It makes no sense to raise a constant. The exception should be raised
  instead.

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloudcafe/+bug/1339855/+subscriptions


References