yahoo-eng-team team mailing list archive

[Matt Riedemann <mriedem@xxxxxxxxxx>]

Sounds like _unshelve_instance in the compute manager just needs to call
_shutdown_instance in case of a failure from the virt driver.spawn()
method, like in _build_resources.

** Tags added: compute shelve unshelve

** Also affects: nova/mitaka
   Importance: Undecided
       Status: New

** Also affects: nova/newton
   Importance: Undecided
       Status: New

** Changed in: nova
       Status: New => Confirmed

** Changed in: nova/mitaka
       Status: New => Confirmed

** Changed in: nova/newton
       Status: New => Confirmed

** Summary changed:

- unshelving an instance doesn't rollback volumes connections
+ unshelving an instance doesn't rollback volumes connections on failure

** Changed in: nova
   Importance: Undecided => Low

** Changed in: nova/newton
   Importance: Undecided => Low

** Changed in: nova/mitaka
   Importance: Undecided => Low

** Tags added: low-hanging-fruit

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1627694

Title:
  unshelving an instance doesn't rollback volumes connections on failure

Status in OpenStack Compute (nova):
  Confirmed
Status in OpenStack Compute (nova) mitaka series:
  Confirmed
Status in OpenStack Compute (nova) newton series:
  Confirmed

Bug description:
  When creating and instance and it is being spawned for the first time
  fails, the instance's volumes' initialize_connection is being rolled-
  back, but when unshelving an shelved-offloaded instance, there's no
  rollback in case of failure.

  The reason is that when spawning an instance for the first time, nova-compute calls initialize_connection using the _build_resources() method:
  https://github.com/openstack/nova/blob/93e689516da0302b06c2760bb82c5004ae057913/nova/compute/manager.py#L1902
  That context-aware method will also take care of rollback in case of a failure in spawning, and will terminate_connection of the volumes:
  https://github.com/openstack/nova/blob/93e689516da0302b06c2760bb82c5004ae057913/nova/compute/manager.py#L2095

  But, when unshelving an instance, initialize_connection is not called in a context aware method, and no rollback in happening when spawning fails.
  https://github.com/openstack/nova/blob/93e689516da0302b06c2760bb82c5004ae057913/nova/compute/manager.py#L4330

  This makes the volumes stay connected to the node even-though the instance is shelved-offloaded.
  If you want to see this problem, replace the driver.spawn() call with a "raise Exception", and see the volumes have connection to the node even though they shouldn't have.

  I'm using openstack Liberty, but I can see this problem in current
  master (pre-Newton)

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1627694/+subscriptions