yahoo-eng-team team mailing list archive
-
yahoo-eng-team team
-
Mailing list archive
-
Message #57552
[Bug 1630410] Re: fixed_ips list out of order
Reviewed: https://review.openstack.org/382121
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=bd1c454c4f6de69eec7b3814b90faeb4db371ba6
Submitter: Jenkins
Branch: master
commit bd1c454c4f6de69eec7b3814b90faeb4db371ba6
Author: Kevin Benton <kevin@xxxxxxxxxx>
Date: Tue Oct 4 18:38:07 2016 -0600
Deterministic ordering of fixed_ips
This adds an order_by clause to the fixed_ips relationship
on the port object to ensure that the fixed_ip ordering is
consistent between a create, an update, and a get request
for a port. Without it we were at the mercy of the sql backend
to determine how it felt like ordering them on the join condition.
Closes-Bug: #1630410
Change-Id: I523e0ab6e376f5ff6205b1cc1748aa6d546919cb
** Changed in: neutron
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1630410
Title:
fixed_ips list out of order
Status in neutron:
Fix Released
Bug description:
Change [1], led to failures like [2], in that the order of fixed_ips
is no longer preserved between POST and GET requests. This was taken
care for some other attributes of the Port resource like allowed
address pairs, but not all.
Even though the API is lax about the order of specific attributes, we
should attempt to restore the old behavior to avoid more damaging side
effects in clients that are assuming the list be returned in the order
in which fixed IPs are created.
[1] https://review.openstack.org/#/c/373582
[2] http://logs.openstack.org/63/377163/4/check/gate-shade-dsvm-functional-neutron/e621e3d/console.html
To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1630410/+subscriptions
References