yahoo-eng-team team mailing list archive

[Launchpad Bug Tracker <1576692@xxxxxxxxxxxxxxxxxx>]

This bug was fixed in the package init-system-helpers - 1.29ubuntu3

---------------
init-system-helpers (1.29ubuntu3) xenial-proposed; urgency=medium

  * invoke-rc.d, service: Only ignore systemd unit dependencies before
    multi-user.target. "systemctl is-system-running" might still be false in
    case of running jobs  for device/mount/hotplug/dynamic actions units. But
    in those cases we already do want to respect unit dependencies, as the
    system is booted up sufficiently to avoid dependency loops. Thus weaken
    the condition to "multi-user.target is active".

    This does not change the behaviour for single-user: is-system-running has
    always been false there, so dependencies continue to be ignored.

    Fixes installation of packages like PostgreSQL under cloud-init or when
    manually installing packages right after booting.

    LP: #1576692

 -- Martin Pitt <martin.pitt@xxxxxxxxxx>  Mon, 12 Sep 2016 10:57:57
+0200

** Changed in: init-system-helpers (Ubuntu Xenial)
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to cloud-init.
https://bugs.launchpad.net/bugs/1576692

Title:
  fully support package installation in systemd

Status in cloud-init:
  Fix Released
Status in cloud-init package in Ubuntu:
  Fix Released
Status in init-system-helpers package in Ubuntu:
  Fix Released
Status in cloud-init source package in Xenial:
  Fix Released
Status in init-system-helpers source package in Xenial:
  Fix Released

Bug description:
  in cloud-init users can install packages via cloud-config:
  #cloud-config
  packages: [apache2]

  Due to some intricacies of systemd and service installation that doesn't work all that well.
  We fixed the issue for simple services that do not have any dependencies on other services, or at least don't check those dependencies well under bug 1575572.

  We'd like to have a way to fully support this in cloud-init.

  Related bugs:
   * bug 1575572:  apache2 fails to start if installed via cloud config (on Xenial)
   * bug 1611973: postgresql@9.5-main service not started if postgres installed via cloud-init
   * bug 1621336: snapd.boot-ok.service hangs eternally on cloud image upgrades (snapd packaging bug, but this cloud-init fix will workaround it)
   * bug 1620780: dev-sda2.device job running and times out
   * bug 1623570: Azure: cannot start walinux agent (Transaction order is cyclic.)
   * bug 1623868: cloud-final.service does not run due to dependency cycle
   * bug 1627436: [gce] Startup scripts do not run on 1604 images
   * bug 1624596: [azure] ephemeral-disk-warning.service causes ordering cycle on multi-user.target 

  SRU INFORMATION
  ===============
  FIX for init-system-helpers: https://anonscm.debian.org/cgit/collab-maint/init-system-helpers.git/commit/?id=1460d6a02

  REGRESSION POTENTIAL for init-system-helpers: This changes invoke-rc.d
  and service, two very central pieces of packaging infrastructure.
  Errors in it will break installation/upgrades of packages or
  /etc/network/if-up.d/ hooks and the like. This changes the condition
  when systemd units get started without their dependencies, and the
  condition gets weakened. This means that behaviour in a booted system
  is unchanged, but during boot this could change the behaviour of if-
  up.d/ hooks (although they have never been defined well during boot
  anyway). However, I tested this change extensively in cloud images and
  desktop installations (particularly I recreated
  https://bugs.debian.org/777113 and confirmed that this approach also
  fixes it) and could not find any regression.

  TEST CASE (for both packages):
  Run
     lxc launch ubuntu-daily:x --config=user.user-data="$(printf "#cloud-config\npackages: [postgresql, samba, postfix]")" x1

  This will install all three packages, but "systemctl status
  postgresql@9.5-main" will not be running.

  Now prepare a new image with the proposed cloud-init and init-system-
  helpers:

     lxc launch ubuntu-daily:x xprep
     lxc exec xprep bash
     # enable -proposed and dist-upgrade, then poweroff
     lxc publish xprep x-proposed

  Now run the initial lxc launch again, but against that new x-proposed
  image instead of the standard daily:

    lxc launch x-proposed --config=user.user-data="$(printf "#cloud-
  config\npackages: [postgresql, samba, postfix]")" x1

  You should now have "systemctl status postgresql@9.5-main" running.
  Directly after rebooting the instance, check that there are no hanging
  jobs (systemctl list-jobs), particularly networking.service, to ensure
  that https://bugs.debian.org/777113 did not come back.

  Also test interactively installing a package that ships a service,
  like "apache2", and verify that it starts properly after installation.

  Verify that journalctl shows no dependency cycles and that all cloud
  init services and the target are active:

  $ systemctl list-units --no-legend --all 'cloud*'
  cloud-config.service     loaded active exited Apply the settings specified in cloud-config
  cloud-final.service      loaded active exited Execute cloud user/final scripts
  cloud-init-local.service loaded active exited Initial cloud-init job (pre-networking)
  cloud-init.service       loaded active exited Initial cloud-init job (metadata service crawler)
  cloud-config.target      loaded active active Cloud-config availability
  cloud-init.target        loaded active active Cloud-init target

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-init/+bug/1576692/+subscriptions