← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1631930] [NEW] Horizon default container name 'volumebackups' for volume backups could be invalid

 

Public bug reported:

Currently Horizon uses 'volumebackups' name as a default name for
container if user ignored thid field in CreateBackup form:
https://github.com/openstack/horizon/blob/stable/newton/openstack_dashboard/dashboards/project/volumes/backups/forms.py#L46

And in some cases `volumebackups` could be wrong name. For example, if
Ceph is used as a backend:
https://github.com/openstack/cinder/blob/b67d13ef4b9ac7d0bba92250ac5a77c15d8e9e68/cinder/backup/drivers/ceph.py#L84

If Horizon passes wrong default value, Cinder will fail creation of
backup with an error like this: `oslo_messaging.rpc.dispatcher
ObjectNotFound: error opening pool 'volumebackups'`

And since Cinder is able to fill missing value with correct default name
it is better to remove this Hardcode from Horizon side.

** Affects: horizon
     Importance: Undecided
     Assignee: Paul Karikh (pkarikh)
         Status: New

** Changed in: horizon
     Assignee: (unassigned) => Paul Karikh (pkarikh)

** Description changed:

  Currently Horizon uses 'volumebackups' name as a default name for
  container if user ignored thid field in CreateBackup form:
  https://github.com/openstack/horizon/blob/stable/newton/openstack_dashboard/dashboards/project/volumes/backups/forms.py#L46
  
  And in some cases `volumebackups` could be wrong name. For example, if
  Ceph is used as a backend:
  https://github.com/openstack/cinder/blob/b67d13ef4b9ac7d0bba92250ac5a77c15d8e9e68/cinder/backup/drivers/ceph.py#L84
  
+ If Horizon passes wrong default value, Cinder will fail creation of
+ backup with an error like this: `oslo_messaging.rpc.dispatcher
+ ObjectNotFound: error opening pool 'volumebackups'`
+ 
  And since Cinder is able to fill missing value with correct default name
  it is better to remove this Hardcode from Horizon side.

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1631930

Title:
  Horizon default container name 'volumebackups' for volume backups
  could be invalid

Status in OpenStack Dashboard (Horizon):
  New

Bug description:
  Currently Horizon uses 'volumebackups' name as a default name for
  container if user ignored thid field in CreateBackup form:
  https://github.com/openstack/horizon/blob/stable/newton/openstack_dashboard/dashboards/project/volumes/backups/forms.py#L46

  And in some cases `volumebackups` could be wrong name. For example, if
  Ceph is used as a backend:
  https://github.com/openstack/cinder/blob/b67d13ef4b9ac7d0bba92250ac5a77c15d8e9e68/cinder/backup/drivers/ceph.py#L84

  If Horizon passes wrong default value, Cinder will fail creation of
  backup with an error like this: `oslo_messaging.rpc.dispatcher
  ObjectNotFound: error opening pool 'volumebackups'`

  And since Cinder is able to fill missing value with correct default
  name it is better to remove this Hardcode from Horizon side.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1631930/+subscriptions


Follow ups