← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1632080] Re: Adding routes to router does not increment its revision number

 

Reviewed:  https://review.openstack.org/384688
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=29e15f9278e8d81fa4d8722deadd8739af60eb51
Submitter: Jenkins
Branch:    master

commit 29e15f9278e8d81fa4d8722deadd8739af60eb51
Author: Omer Anson <omer.anson@xxxxxxxxxxxxxxxx>
Date:   Mon Oct 10 22:46:32 2016 +0300

    Have RouterRoute object increment Router revision
    
    When modifying RouterRoute objects on a Router (e.g. adding a route to a
    router via the ExtraRoute extension), have the modification update the
    Router's revision number.
    
    Change-Id: If9bb56442375efac3043b9de0a03972552ac34bf
    Closes-Bug: 1632080


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1632080

Title:
  Adding routes to router does not increment its revision number

Status in neutron:
  Fix Released

Bug description:
  Adding routes to router does not increment its revision number:

  As per the following output, note that revision_number is 3 after the call to openstack router set (which succeeded):
  [stack@l1 ~]$ openstack router show r1                                                                                                                                  
  +-----------------------+-----------------------------------------------+
  | Field                 | Value                                         |
  +-----------------------+-----------------------------------------------+
  | admin_state_up        | UP                                            |
  | created_at            | 2016-10-10T17:18:45Z                          |
  | description           |                                               |
  | external_gateway_info | null                                          |
  | id                    | d7400cc1-1ad4-47b4-9a58-f86f0baf7f06          |
  | name                  | r1                                            |
  | project_id            | b370e3cd05504661967a04cb119d50ec              |
  | project_id            | b370e3cd05504661967a04cb119d50ec              |
  | revision_number       | 3                                             |
  | routes                | destination='10.0.3.0/24', gateway='10.0.1.4' |
  | status                | ACTIVE                                        |
  | updated_at            | 2016-10-10T18:48:31Z                          |
  +-----------------------+-----------------------------------------------+
  [stack@l1 ~]$ openstack router set --route destination=10.0.4.0/24,gateway=10.0.1.4  r1                                                                                 
  [stack@l1 ~]$ openstack router show r1
  +-----------------------+-----------------------------------------------+
  | Field                 | Value                                         |
  +-----------------------+-----------------------------------------------+
  | admin_state_up        | UP                                            |
  | created_at            | 2016-10-10T17:18:45Z                          |
  | description           |                                               |
  | external_gateway_info | null                                          |
  | id                    | d7400cc1-1ad4-47b4-9a58-f86f0baf7f06          |
  | name                  | r1                                            |
  | project_id            | b370e3cd05504661967a04cb119d50ec              |
  | project_id            | b370e3cd05504661967a04cb119d50ec              |
  | revision_number       | 3                                             |
  | routes                | destination='10.0.4.0/24', gateway='10.0.1.4' |
  |                       | destination='10.0.3.0/24', gateway='10.0.1.4' |
  | status                | ACTIVE                                        |
  | updated_at            | 2016-10-10T18:48:31Z                          |
  +-----------------------+-----------------------------------------------+

  
  Expected output: revision_number is 4 (or more) on the second call to openstack router show r1.

  Found on commit 355c145 Merge "Cleanup Newton Release Notes"

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1632080/+subscriptions


References