← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1608980] Re: Remove MANIFEST.in as it is not explicitly needed by PBR

 

Reviewed:  https://review.openstack.org/385918
Committed: https://git.openstack.org/cgit/openstack/octavia/commit/?id=9fe5317e004e723d5ad9141cf1e5e90c5f8fe2e5
Submitter: Jenkins
Branch:    master

commit 9fe5317e004e723d5ad9141cf1e5e90c5f8fe2e5
Author: Deepak <deepak.os31@xxxxxxxxx>
Date:   Thu Oct 13 16:57:37 2016 +0530

    Drop MANIFEST.in - it's not needed by pbr
    
    octavia already uses PBR:-
    setuptools.setup(
        setup_requires=['pbr>=1.8'],
        pbr=True)
    
    This patch removes `MANIFEST.in` file as pbr generates a
    sensible manifest from git files and some standard files
    and it removes the need for an explicit `MANIFEST.in` file.
    
    Change-Id: I0b6a7a6eb3be8c1982a4fd7576dea1db9890f69c
    Closes-Bug: #1608980


** Changed in: octavia
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1608980

Title:
  Remove MANIFEST.in as it is not explicitly needed by PBR

Status in craton:
  In Progress
Status in ec2-api:
  Confirmed
Status in gce-api:
  Confirmed
Status in Karbor:
  New
Status in Kosmos:
  New
Status in Magnum:
  Fix Released
Status in masakari:
  In Progress
Status in neutron:
  In Progress
Status in Neutron LBaaS Dashboard:
  Confirmed
Status in octavia:
  Fix Released
Status in OpenStack Search (Searchlight):
  New
Status in Solum:
  In Progress
Status in Tricircle:
  Fix Released
Status in OpenStack DBaaS (Trove):
  In Progress
Status in watcher:
  In Progress
Status in Zun:
  Fix Released

Bug description:
  PBR do not explicitly require MANIFEST.in, so it can be removed.

  
  Snippet from: http://docs.openstack.org/infra/manual/developers.html

  Manifest

  Just like AUTHORS and ChangeLog, why keep a list of files you wish to
  include when you can find many of these in git. MANIFEST.in generation
  ensures almost all files stored in git, with the exception of
  .gitignore, .gitreview and .pyc files, are automatically included in
  your distribution. In addition, the generated AUTHORS and ChangeLog
  files are also included. In many cases, this removes the need for an
  explicit ‘MANIFEST.in’ file

To manage notifications about this bug go to:
https://bugs.launchpad.net/craton/+bug/1608980/+subscriptions