← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1608980] Re: Remove MANIFEST.in as it is not explicitly needed by PBR

 

Reviewed:  https://review.openstack.org/385905
Committed: https://git.openstack.org/cgit/openstack/craton/commit/?id=4b17e89c76a90d3cb934c554927e27d839fda53e
Submitter: Jenkins
Branch:    master

commit 4b17e89c76a90d3cb934c554927e27d839fda53e
Author: Deepak <deepak.os31@xxxxxxxxx>
Date:   Thu Oct 13 16:26:20 2016 +0530

    Drop MANIFEST.in - it's not needed by pbr
    
    craton already uses PBR:-
    setuptools.setup(
        setup_requires=['pbr'],
        pbr=True)
    
    This patch removes `MANIFEST.in` file as pbr generates a
    sensible manifest from git files and some standard files
    and it removes the need for an explicit `MANIFEST.in` file.
    
    Change-Id: I52408a14c7e901e36b6a1d79ec2058d2c8e4dcd6
    Closes-Bug: #1608980


** Changed in: craton
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1608980

Title:
  Remove MANIFEST.in as it is not explicitly needed by PBR

Status in craton:
  Fix Released
Status in ec2-api:
  In Progress
Status in gce-api:
  Fix Released
Status in Karbor:
  In Progress
Status in OpenStack Identity (keystone):
  In Progress
Status in Kosmos:
  New
Status in Magnum:
  Fix Released
Status in masakari:
  Fix Released
Status in neutron:
  Fix Released
Status in Neutron LBaaS Dashboard:
  Confirmed
Status in octavia:
  Fix Released
Status in python-searchlightclient:
  In Progress
Status in OpenStack Search (Searchlight):
  In Progress
Status in Solum:
  In Progress
Status in Swift Authentication:
  In Progress
Status in OpenStack Object Storage (swift):
  In Progress
Status in Tricircle:
  Fix Released
Status in OpenStack DBaaS (Trove):
  Fix Released
Status in watcher:
  Fix Released
Status in Zun:
  Fix Released

Bug description:
  PBR do not explicitly require MANIFEST.in, so it can be removed.

  
  Snippet from: http://docs.openstack.org/infra/manual/developers.html

  Manifest

  Just like AUTHORS and ChangeLog, why keep a list of files you wish to
  include when you can find many of these in git. MANIFEST.in generation
  ensures almost all files stored in git, with the exception of
  .gitignore, .gitreview and .pyc files, are automatically included in
  your distribution. In addition, the generated AUTHORS and ChangeLog
  files are also included. In many cases, this removes the need for an
  explicit ‘MANIFEST.in’ file

To manage notifications about this bug go to:
https://bugs.launchpad.net/craton/+bug/1608980/+subscriptions