← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1619602] Re: Hyper-V: vhd config drive images are not migrated

 

Reviewed:  https://review.openstack.org/387361
Committed: https://git.openstack.org/cgit/openstack/compute-hyperv/commit/?id=93a4cb6207ed35b7b5325b5b03bff5126677695f
Submitter: Jenkins
Branch:    master

commit 93a4cb6207ed35b7b5325b5b03bff5126677695f
Author: Lucian Petrut <lpetrut@xxxxxxxxxxxxxxxxxxxxxx>
Date:   Mon Oct 17 14:20:12 2016 +0300

    HyperV: ensure config drives are copied as well during resizes
    
    During cold migration, vhd config drive images are not copied
    over, on the wrong assumption that the instance is already
    configured and does not need the config drive.
    
    For this reason, migrating instances using vhd config drives
    will fail, as there is a check ensuring that the config drive
    is present, if required.
    
    This change addresses the issue, removing the check that was
    preventing the config drive from being copied.
    
    (cherry-picked from commit 2dd231cff199bd75bcd3d1031a9ff0a1a82ec1cb)
    
    Change-Id: I8cd42bed4515f4f75c92e595c4d8b847b16058dd
    Closes-Bug: #1619602


** Changed in: compute-hyperv
       Status: New => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1619602

Title:
  Hyper-V: vhd config drive images are not migrated

Status in compute-hyperv:
  Fix Released
Status in OpenStack Compute (nova):
  Fix Released
Status in OpenStack Compute (nova) newton series:
  Fix Committed

Bug description:
  During cold migration, vhd config drive images are not copied over, on
  the wrong assumption that the instance is already configured and does
  not need the config drive.

  There is an explicit check at the following location:
  https://github.com/openstack/nova/blob/8f35bb321d26bd7d296c57f4188ec12fcde897c3/nova/virt/hyperv/migrationops.py#L75-L76

  For this reason, migrating instances using vhd config drives will fail, as there is a check ensuring that the config drive is present, if required:
  https://github.com/openstack/nova/blob/8f35bb321d26bd7d296c57f4188ec12fcde897c3/nova/virt/hyperv/migrationops.py#L153-L163

  The Hyper-V driver should not skip moving the config drive image.

To manage notifications about this bug go to:
https://bugs.launchpad.net/compute-hyperv/+bug/1619602/+subscriptions


References